Configurable search providers from config#515
Merged
nf-s merged 14 commits intoTerriaJS:mainfrom Nov 24, 2023
Merged
Conversation
6 tasks
ljowen
reviewed
Nov 20, 2023
Contributor
ljowen
left a comment
ljowen
left a comment
There was a problem hiding this comment.
Looks good! Added CesiumIon search as that will become the default
| "fallbackLanguage": "en" | ||
| }, | ||
| "searchBarModel": {}, | ||
| "searchProviders": [ |
Contributor
There was a problem hiding this comment.
Suggested change
| "searchProviders": [ | |
| "searchProviders": [ | |
| { | |
| "id": "search-provider/cesium-ion-search-provider", | |
| "type": "cesium-ion-search-provider", | |
| "url": "https://api.cesium.com/v1/geocode/search", | |
| "flightDurationSeconds": 1.5 | |
| }, |
Collaborator
Author
There was a problem hiding this comment.
added, just have to wait for terriajs release before merging this
Contributor
|
@nf-s since this PR updated CHANGES.md and added a date that is now a few days old, should there be a release 0.0.9 of TerriaMap? |
Contributor
|
Good point @pjonsson! Sorry for the delay, I just triggered the release |
Contributor
|
@nf-s Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TerriaMap work for #5145