Merged
Conversation
na9da
force-pushed
the
fix-plugin-init
branch
2 times, most recently
from
0cb8973 to
c04a9eb
Compare
Plugins must be initialized before restoring app state from share data as it might reference plugin components and catalog items.
4 tasks
mwu2018
suggested changes
Jun 23, 2022
mwu2018
approved these changes
Jun 28, 2022
Contributor
Author
|
Thanks @mwu2018 - Will merge after a new release of terriajs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugins must be initialized before restoring app state from share data as it might reference
plugin components and catalog items.
Depends on TerriaJS/terriajs#6342
Test me
Open http://ci.terria.io/main/
Check the map settings, it'll be in
3d smoothSwitch to
3d terrainNow reload the page and check map settings again. Correct behavior is the switch to
3d terrainmust persist. But now the settings is incorrectly set to3d smooth.Now run an instance from this branch
fix-plugin-initThe above incorrect behavior should be fixed
Next, try opening the sample plugin from the right hand map menu (Cube icon)
Verify it opens correctly without errors