chore(ui): move Outbound Webhooks back to Settings#199
Merged
TerrifiedBug merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
Outbound Webhooks fire on lifecycle events (deploys, version changes, fleet activity, backup failures) — not alert rule evaluations. Hosting them under Alerts > Channels conflated two different concepts: - NotificationChannel: per-environment alert routing (alert rule fires → channel delivers) - OutboundWebhook: team-scoped event firehose (no rule needed) Move OutboundWebhooksSection to /settings/webhooks (its original home, which has been a redirect since the consolidation in #176). Settings already hosts comparable integration-style configs (auth, SCIM, audit shipping, telemetry, backup), making it the natural place for outbound event subscriptions. Also surfaces the section as a card on the Settings overview so it's discoverable; the command palette entry already pointed at the new URL. Alerts > Channels now contains only Notification Channels.
TerrifiedBug
added a commit
that referenced
this pull request
Apr 28, 2026
PR #199 wired the page route and the settings-overview card but left settings-sidebar-nav.tsx untouched, so the page was unreachable from the sidebar. Add it to the Organization group alongside Service Accounts and AI (other team-level integrations) with the Webhook icon. Non-super-admin so team editors can manage event subscriptions, demo- hidden to match other integration entries.
5 tasks
TerrifiedBug
added a commit
that referenced
this pull request
Apr 28, 2026
…log (#200) * fix(audit): redact NotificationChannel secret config fields in audit log The audit middleware sanitizer (src/server/middleware/audit.ts) only redacted exact-key matches for password/token/secret/etc. Channel-config secret fields slipped through unredacted, causing AuditLog.metadata to store plaintext webhook signing secrets, SMTP passwords, PagerDuty routing keys, and webhook URLs (which often embed auth tokens) on every notificationChannel.created / .updated / .deleted action. This undermined the encrypt-at-rest fix landed in PR #198, which closed plaintext storage in the channel.config column itself but left the audit-log side channel open. Changes: - Add hmacSecret, smtpPass, integrationKey, webhookUrl to SENSITIVE_KEYS. - Extract SENSITIVE_KEYS / sanitizeInput / computeDiff into a separate audit-sanitize module so they can be unit-tested without pulling in the full Prisma + NextAuth runtime via the middleware barrel. - Add unit tests covering top-level redaction, nested config redaction, arrays of channels, primitive passthrough, null/undefined, and presence of the new keys in the set. * fix(settings): add Outbound Webhooks entry to settings sidebar nav PR #199 wired the page route and the settings-overview card but left settings-sidebar-nav.tsx untouched, so the page was unreachable from the sidebar. Add it to the Organization group alongside Service Accounts and AI (other team-level integrations) with the Webhook icon. Non-super-admin so team editors can manage event subscriptions, demo- hidden to match other integration entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
NotificationChannels (alerts tab) and OutboundWebhooks (event firehose) are different concepts despite both being "webhooks":
Hosting them on the same page conflated the two. Settings is the natural home alongside other integration-style configs (auth, SCIM, audit shipping, telemetry, backup).
Test plan