Skip to content

feat: add project installer#148

Merged
Terry-Mao merged 9 commits into
mainfrom
feat/install-script-146
May 21, 2026
Merged

feat: add project installer#148
Terry-Mao merged 9 commits into
mainfrom
feat/install-script-146

Conversation

@Terry-Mao
Copy link
Copy Markdown
Owner

Closes #146

Summary

  • Add a Bash installer for syncing AICodingFlow skills and GitHub automation into target repositories.
  • Preserve existing repo-local companion skills while allowing regular skills and workflow support files to update.
  • Document clone-based and curl-based installation, dry-run usage, dependencies, and optional bootstrap-issue-config setup.

Validation

  • bash -n install.sh
  • PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s .github/tests -p 'test_install_script.py'
  • PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s .github/tests
  • git diff --check

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found: 0 critical, 1 important, 0 suggestions. The installer can use the caller's working directory as its source during curl-based installs, so the documented one-line update path can silently copy stale or unrelated files instead of the current AICodingFlow release.

Comment thread install.sh Outdated
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found: 0 critical, 1 important, 0 suggestions. The installer copies the generated workflow test suite into target repositories, but the newly added installer tests require a root install.sh that is not installed, so target repos that run the copied tests fail immediately.

Comment thread install.sh
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found: 0 critical, 1 important, 0 suggestions. The installer currently leaks this repository's repo-local companion skills into fresh target repositories.

Comment thread install.sh Outdated
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found: 0 critical, 1 important, 0 suggestions.

Comment thread .agents/skills/review-pr-local/SKILL.md Outdated
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found: 0 critical, 1 important, 0 suggestions. The installer dry-run path can fail on a clean target before reporting the planned installation.

Comment thread install.sh Outdated
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found: 0 critical, 1 important, 0 suggestions. The local review preparation guard was removed while the local wrapper skills still instruct a fixed review skill, so invoking the wrong local wrapper can now silently run the wrong review workflow.

Comment thread .github/scripts/prepare_local_review_inputs.py
@github-actions
Copy link
Copy Markdown
Contributor

Applied requested changes on feat/install-script-146.

Summary:

Summary

  • Update local review skill instructions to read and follow the selected skill=<path> emitted by prepare_local_review_inputs.py.
  • Remove the stale --expected-skill example from repository agent guidance.
  • Add a regression test for the selected-skill local review contract.

Validation

  • PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s .github/tests -p 'test_implementation_skill_guidance.py'
  • PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s .github/tests -p 'test_prepare_local_review_inputs.py'

#148

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found: 0 critical, 0 important, 1 suggestion.

Comment thread .github/scripts/select_review_skill.py
@github-actions
Copy link
Copy Markdown
Contributor

Applied requested changes on feat/install-script-146.

Summary:

Summary

  • Update README review workflow docs to describe selection of core review-pr and review-spec skills.
  • Clarify that repo-local review companions are loaded by those core skills rather than selected directly.

Validation

  • git diff --check

#148

@Terry-Mao
Copy link
Copy Markdown
Owner Author

@kratos-ci-bot /review

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking findings found.

@Terry-Mao Terry-Mao merged commit bfe4dad into main May 21, 2026
1 check passed
@Terry-Mao Terry-Mao deleted the feat/install-script-146 branch May 21, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

提供一个安装脚本,方便一键安装到其他项目中

1 participant