Skip to content

fix(review): dismiss stale bot request changes#162

Merged
Terry-Mao merged 4 commits into
mainfrom
feat/review-reject-pr-flow-151
May 23, 2026
Merged

fix(review): dismiss stale bot request changes#162
Terry-Mao merged 4 commits into
mainfrom
feat/review-reject-pr-flow-151

Conversation

@Terry-Mao
Copy link
Copy Markdown
Owner

Summary

  • map PR review REJECT/APPROVE follow-up behavior so stale bot-authored REQUEST_CHANGES reviews can be dismissed on later APPROVE
  • add REVIEW_BOT_LOGIN wiring and docs for custom review bot identities
  • cover dismiss behavior and workflow env wiring in delivered tests

Validation

  • python3 -m unittest test_post_pr_review test_review_workflow_dispatch
  • python3 -m unittest discover -s .github/aicodingflow-tests
  • local review-pr-local: APPROVE

Refs #151

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 0 critical, 1 important, 0 suggestions. The new stale-review dismissal path needs a stricter author check before merge.

Comment thread .github/scripts/post_pr_review.py Outdated
@github-actions
Copy link
Copy Markdown
Contributor

Applied requested changes on feat/review-reject-pr-flow-151.

Summary:

Summary

  • require stale request-changes dismissal to match both the configured review bot login and a bot identity
  • add regression coverage so a configured human login is not eligible for stale bot review dismissal

Validation

  • python3 -m unittest test_post_pr_review

#162

@Terry-Mao
Copy link
Copy Markdown
Owner Author

@kratos-ci-bot /review

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found: 0 critical, 1 important, 0 suggestions. The stale-review cleanup should stay best-effort; otherwise an APPROVE run can fail after posting the review.

Comment thread .github/scripts/post_pr_review.py Outdated
@github-actions
Copy link
Copy Markdown
Contributor

Applied requested changes on feat/review-reject-pr-flow-151.

Summary:

Summary

  • skip stale bot request-changes cleanup when listing PR reviews fails
  • keep the current PR review publishing flow from failing on best-effort cleanup
  • add regression coverage for transient review-listing failures

Validation

  • python3 -m unittest discover -s .github/aicodingflow-tests -p test_post_pr_review.py

#162

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found: 0 critical, 1 important, 0 suggestions. The stale request-changes dismissal can miss reviews because the GitHub reviews list is paginated; please fetch all review pages or request a sufficiently bounded complete set before deciding dismissal is done.

Comment thread .github/scripts/post_pr_review.py Outdated
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking findings. The stale bot REQUEST_CHANGES dismissal is scoped to later APPROVE verdicts for non-member code PRs, only dismisses reviews authored by the configured bot login, handles review-listing/dismissal failures without interrupting review posting, and the workflow/docs/tests cover the new REVIEW_BOT_LOGIN wiring.

@Terry-Mao Terry-Mao merged commit 8ec1e5f into main May 23, 2026
5 checks passed
@Terry-Mao Terry-Mao deleted the feat/review-reject-pr-flow-151 branch May 23, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant