Fix build failures on MacOS by addressing bash compatibility and OpenSSL download issues #153
+38
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@JoshMcCullough 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: JoshMcCullough <4859660+JoshMcCullough@users.noreply.github.com>
Co-authored-by: JoshMcCullough <4859660+JoshMcCullough@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Build fails on MacOS
Fix build failures on MacOS by addressing cross-platform compatibility issues
Aug 20, 2025
Copilot finished work on behalf of
JoshMcCullough
August 20, 2025 20:08
Co-authored-by: JoshMcCullough <4859660+JoshMcCullough@users.noreply.github.com>
Copilot
AI
changed the title
Fix build failures on MacOS by addressing cross-platform compatibility issues
Fix build failures on MacOS by addressing bash compatibility and OpenSSL download issues
Aug 20, 2025
Copilot finished work on behalf of
JoshMcCullough
August 20, 2025 20:52
JoshMcCullough
approved these changes
Aug 20, 2025
Contributor
|
@joan7770 please report back here if this resolves the Mac build issues or what work is left to do. |
Contributor
|
@JoshMcCullough Builds fine now |
JoshMcCullough
approved these changes
Aug 20, 2025
Contributor
|
Very nice, @JoshMcCullough |
JoshMcCullough
added a commit
to w453y/ngx-http-auth-jwt-module
that referenced
this pull request
Sep 17, 2025
…SSL download issues (TeslaGov#153) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JoshMcCullough <4859660+JoshMcCullough@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the MacOS build issues identified in #132 with minimal, surgical changes to ensure cross-platform compatibility without breaking existing Linux workflows.
Issues Fixed
1. Bash Version Compatibility
MacOS ships with bash 3.2.57 which doesn't support
declare -A(associative arrays require bash 4.0+). The scripts used hardcoded/bin/bashshebangs.Solution: Updated shebangs from
#!/bin/bash -euto#!/usr/bin/env bashwith separateset -eulines, allowing the system to find the appropriate bash version.2. OpenSSL Download Failures
The OpenSSL download URL redirects from
openssl.orgto GitHub, but curl wasn't following redirects, causing silent failures.Solution:
https://github.com/openssl/openssl/releases/download/openssl-${SSL_VERSION}/openssl-${SSL_VERSION}.tar.gz--locationflag to curl for redirect handling3. Docker Logging Driver
The default
journaldlogging driver isn't available on MacOS, requiring manual environment variable changes.Solution: Changed default from
journaldtojson-filein docker-compose, which works universally. Linux users can still setLOG_DRIVER=journaldif preferred.Documentation Updates
json-fileandjournaldoptionsTesting
✅ All bash scripts pass syntax validation
✅ Script functions execute correctly with associative arrays
✅ Changes are minimal and focused on actual compatibility issues
✅ No breaking changes to existing workflows
The build should now work seamlessly on both Linux and MacOS without requiring manual file modifications.
Fixes #132.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.