Skip to content

Master#4

Merged
Nimrostafarian merged 7 commits into
mainfrom
master
Jan 18, 2023
Merged

Master#4
Nimrostafarian merged 7 commits into
mainfrom
master

Conversation

@Nimrostafarian
Copy link
Copy Markdown
Contributor

Closes: #XXX

Context and purpose of the change

Brief Changelog

Author's Checklist

I have...

  • Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?
  • This pull request updates existing proto field values (and require a backend and frontend migration)?
  • Does this pull request change existing proto field names (and require a frontend migration)?
    How is the feature or change documented?
    • not applicable
    • jira ticket XXX
    • specification (x/<module>/spec/)
    • README.md
    • not documented

@github-actions github-actions Bot added dependencies Pull requests that update a dependency file C:app-wiring T:CI C:CLI C:proto labels Jan 18, 2023
@Nimrostafarian Nimrostafarian merged commit 38711d8 into main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:app-wiring C:CLI C:proto dependencies Pull requests that update a dependency file T:CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant