Skip to content

Ensure trailing slashes in session.mount() URLs #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2025
Merged

Ensure trailing slashes in session.mount() URLs #93

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c15c4bc
refactor: ensure / in the end of uri
allrob23 Apr 25, 2025
694f236
fix: handle missing requests_mock.compat import gracefully
allrob23 Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion stackinabox/util/requests_mock/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,18 @@
from requests.adapters import HTTPAdapter
from urllib3.response import HTTPResponse
import requests_mock
import requests_mock.compat
import requests_mock.response
import six

from stackinabox.stack import StackInABox
from stackinabox.util import deprecator
from stackinabox.util.requests_mock import reqcallable

try:
import requests_mock.compat
except ImportError:
pass


logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -52,6 +56,9 @@ def session_registration(uri, session):
reqcallable.RequestMockCallable(uri)
)

if not uri.endswith('/'):
uri += '/'

# Tell the session about the adapter and the URI
session.mount('http://{0}'.format(uri), StackInABox.hold_out('adapter'))
session.mount('https://{0}'.format(uri), StackInABox.hold_out('adapter'))
Expand Down