Skip to content

Refactor delay instance building #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BenjamenMeyer merged 7 commits into from
Jun 16, 2016
Merged

Refactor delay instance building #9

BenjamenMeyer merged 7 commits into from
Jun 16, 2016

Conversation

@BenjamenMeyer
Copy link
Member

@BenjamenMeyer BenjamenMeyer commented Jun 15, 2016

Refactor from the initial POC to a usable service set that allows one to dynamically manage sessions for use (create, reset, destroy).

  • resetting a session will destroy then create a new session with the same session id
  • StackInABoxServices must be specified by type and will be auto-instantiated when a session is created
  • 100% code coverage
  • adds an admin interface as /admin/ where the following operations can be done:
    • POST - creates a session
    • PUT - resets a session
    • DELETE - deletes a session
  • sessions are available under /stackinabox/<session-id>/

@BenjamenMeyer
Refactor: dynamic sessions
373f00b 
- Refactored to delay instantiation of StackInABoxService objects
  until when the session is created.
- Move the sessions under /stackinabox/<session-id>
- Add an admin interface at /admin/
- Add ability for the admin interface to create new sessions
- Add ability for the admin interface to remove sessions
- Add ability for the admin interface to reset sessions

Note: Session Reset is an expensive operation as it has to rebuild
the entire session, not just tell the session to reset its data.
@BenjamenMeyer
Enhancement: Testing the new session object
4ab54b9
@BenjamenMeyer
Enhancement: session manager testing
7d0aabc 
- Initial tests for the session manager
- update for session manager to use the stackinawsgi.exceptions
@BenjamenMeyer
Enhancement: testing of the admin API
709d733
@BenjamenMeyer
Bug Fix: fixes for lint
e16f2bf
@BenjamenMeyer BenjamenMeyer added this to the 0.1 milestone Jun 15, 2016
@BenjamenMeyer BenjamenMeyer self-assigned this Jun 15, 2016
@coveralls
Copy link

coveralls commented Jun 15, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 99.315% when pulling e16f2bf on BenjamenMeyer:refactor_delay_instance_building into 889961e on TestInABox:master.

@coveralls
Copy link

coveralls commented Jun 16, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 99.658% when pulling 01ed9bb on BenjamenMeyer:refactor_delay_instance_building into 889961e on TestInABox:master.

@coveralls
Copy link

coveralls commented Jun 16, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e0bd8e8 on BenjamenMeyer:refactor_delay_instance_building into 889961e on TestInABox:master.

@BenjamenMeyer
Copy link
Member Author

BenjamenMeyer commented Jun 16, 2016

👍

@BenjamenMeyer BenjamenMeyer merged commit 44d7765 into TestInABox:master Jun 16, 2016
This was referenced Jun 16, 2016
Closed
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BenjamenMeyer BenjamenMeyer

Labels

enhancement

Projects

None yet

Milestone

0.1

Development

Successfully merging this pull request may close these issues.

2 participants

@BenjamenMeyer @coveralls