Refactor rights management and Main Page by MrBricodage · Pull Request #138 · TestLinkOpenSourceTRMS/testlink-code

MrBricodage · 2018-01-14T23:42:59Z

Fix 0008177

Use existant rights :
- user_role_assignment (15)
- testproject_user_role_assignment (23)
Add new users rights :
- cfield_assignment (53)
- exec_assign_testcases (54)
Use these rights in Main Menu and Testlink pages.
Refactor roles edit page to group rights by impact (global/project)
Add missing menus in new main page that were proposed in old main page
Add title in MainPage and reorder entries in boxes
fix few little issues seen during validation

…t (23) Show checkboxes in Users/Roles section of the Edit Role Menu

block 1 : TestLink configuration block block 2 : current project configuration Block block 3 : Requirements Block Block 4 : Testcases Block

- Reorder boxes - Reorder content in boxes - Move some rights in others boxes - keywords in TestCases - platforms in TestProject - Merge boxes (trackers) - Remove no more used Boxes - keywords - platforms

- missing french translations - undefined indexes, properties and offset

Review role rights groups in Role Edit to show witch ones are applied globally and witch ones are applied locally

expiration date is not set

cfield_assignment, value 53 add right to roles that have right 18 cfield_management)

Added in TestProject Box

- on Desktop page to display 'Assign CF' menu - In Assign CF page to check the user rights

remove the use of inventoryEnabled as a user right

To allow req monitor and testcase link only if req View or Req Edit is allowed

In custom fields project assignment GUI

use the same pattern for all assign rights

Allow access to users who only had modification right without view right. From navBar and from Desktop

Unused labels not found (th_kw_rights, th_platform_rights) wrong labels called (expiration for expiration_date)

add right to roles that have right 4 (testplan_planning)

Added in TestPlan Box

- on Desktop page to display 'Assign TestCases Execution' menu - In Assign TestCases Execution page to check the user rights - In Add/Remove Test Cases to display the 'assign to user on add' banner is right is set to current user

Delete unused variables

even if user management is not set for the current user

fmancardi

Target of this change is not clear to me, then I'm not able to accept/apply.

fmancardi

Need to compare current GUI with your proposal, before taking a decision about adding.

fmancardi

These changes/additions are OK. I've applied it without doing merge through Github.

fmancardi

These changes/additions are OK. I've applied it without doing merge through Github.

fmancardi

Custom Field Assignment to Test Project
do not want to change current behavior, then cfield_management will remain AND cfield_assignment will be added in OR MODE.

fmancardi

changes on const.inc.php and reqSpecLisTree.php, applied

fmancardi

pull/138/commits/4430d62d5bb5feeafea2ff6132b1b9a5690808e1

Need to review changes to roles.inc.php.
Changes to strings.txt for English applied with minor changes.
Changes to Frech applied AS IS

fmancardi

Do not think is better to move check for inventoryEnable d to template.
Have fixed use of inventory enabled on inventory management right.

Thanks for HEAD UP!

MrBricodage · 2018-02-18T14:27:41Z

"These changes/additions are OK. I've applied it without doing merge through Github." :
It seems that some features have not been merged. Don't know with answers provided if that is a choice of if you didn't see these modifications.

Missing features :

Role 15 and 23 still no used
Edit Role Page still in "old style", not grouped by impact (global/project)
main Page style is not modified (Titles / Reorder boxes)

fmancardi · 2018-02-18T15:41:30Z

i'm working on all changes, but i'm not sure I'm going to add all. regarda Il 18/Feb/2018 15:27, "Bob Le Bricodeur" <notifications@github.com> ha scritto:

…

"These changes/additions are OK. I've applied it without doing merge through Github." : It seems that some features have not been merged. Don't know with answers provided if that is a choice of if you didn't see these modifications. Missing features : - Role 15 and 23 still no used - Edit Role Page still in "old style", not grouped by impact (global/project) - main Page style is not modified (Titles / Reorder boxes) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#138 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOYsVvAL5C6OL5mNT8pvSJpav40JJCbks5tWDNegaJpZM4RdybI> .

Bob Le Bricodeur added 21 commits January 4, 2018 00:19

Display user_role_assignment (15) and testproject_user_role_assignmen…

4430d62

…t (23) Show checkboxes in Users/Roles section of the Edit Role Menu

Review mainPageLeft with new rights

21a39be

block 1 : TestLink configuration block block 2 : current project configuration Block block 3 : Requirements Block Block 4 : Testcases Block

Review Edit Role GUI

2ed637e

- Reorder boxes - Reorder content in boxes - Move some rights in others boxes - keywords in TestCases - platforms in TestProject - Merge boxes (trackers) - Remove no more used Boxes - keywords - platforms

Fix several log notices messages

7aa33c3

- missing french translations - undefined indexes, properties and offset

Add Inventory Management in Project Box on Desktop

d2216d6

Rework global rights / context right use and display

b98e4ed

Review role rights groups in Role Edit to show witch ones are applied globally and witch ones are applied locally

Fix LOCALIZE error in userView

ff56e07

expiration date is not set

Create new right for custom field assignment

c8550be

cfield_assignment, value 53 add right to roles that have right 18 cfield_management)

Display new right in role management

105e82b

Added in TestProject Box

Use cfield_assignment right in pages

b223acb

- on Desktop page to display 'Assign CF' menu - In Assign CF page to check the user rights

Use inventoryEnabled information in template

ef7e3b8

remove the use of inventoryEnabled as a user right

Reorder left page menu in block3

239dc16

To allow req monitor and testcase link only if req View or Req Edit is allowed

Fix LOCALIZE error in TestLink event log

a5ae6d7

In custom fields project assignment GUI

add coherence in assign role text format

be81606

use the same pattern for all assign rights

Access to req and testcases view

5ec599c

Allow access to users who only had modification right without view right. From navBar and from Desktop

Fix LOCALIZE error in TestLink event log

8062adf

Unused labels not found (th_kw_rights, th_platform_rights) wrong labels called (expiration for expiration_date)

Add new right for testcase exec assignment

c80de55

add right to roles that have right 4 (testplan_planning)

Display new right in role management

e3bf457

Added in TestPlan Box

Use exec_assign_testcases right in pages

f376015

- on Desktop page to display 'Assign TestCases Execution' menu - In Assign TestCases Execution page to check the user rights - In Add/Remove Test Cases to display the 'assign to user on add' banner is right is set to current user

Update mainPage files

1ad3cc4

Delete unused variables

use active background for testplan assignment

9300a76

even if user management is not set for the current user

fmancardi reviewed Feb 18, 2018

View reviewed changes

fmancardi approved these changes Feb 18, 2018

View reviewed changes

fmancardi reviewed Feb 18, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor rights management and Main Page#138

Refactor rights management and Main Page#138
MrBricodage wants to merge 21 commits intoTestLinkOpenSourceTRMS:testlink_1_9from
MrBricodage:refactorRightsManagement

MrBricodage commented Jan 14, 2018 •

edited

Loading

Uh oh!

fmancardi left a comment

Uh oh!

fmancardi left a comment

Uh oh!

fmancardi left a comment

Uh oh!

fmancardi left a comment

Uh oh!

fmancardi left a comment

Uh oh!

fmancardi left a comment

Uh oh!

fmancardi left a comment

Uh oh!

fmancardi left a comment

Uh oh!

MrBricodage commented Feb 18, 2018

Uh oh!

fmancardi commented Feb 18, 2018 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

MrBricodage commented Jan 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmancardi left a comment

Choose a reason for hiding this comment

Uh oh!

fmancardi left a comment

Choose a reason for hiding this comment

Uh oh!

fmancardi left a comment

Choose a reason for hiding this comment

Uh oh!

fmancardi left a comment

Choose a reason for hiding this comment

Uh oh!

fmancardi left a comment

Choose a reason for hiding this comment

Uh oh!

fmancardi left a comment

Choose a reason for hiding this comment

Uh oh!

fmancardi left a comment

Choose a reason for hiding this comment

Uh oh!

fmancardi left a comment

Choose a reason for hiding this comment

Uh oh!

MrBricodage commented Feb 18, 2018

Uh oh!

fmancardi commented Feb 18, 2018 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MrBricodage commented Jan 14, 2018 •

edited

Loading