fix: resolve E2E failures, CodeQL warnings, and debug cleanup#216
Merged
therealbrad merged 10 commits intomainfrom Apr 16, 2026
Merged
fix: resolve E2E failures, CodeQL warnings, and debug cleanup#216therealbrad merged 10 commits intomainfrom
therealbrad merged 10 commits intomainfrom
Conversation
- Remove useless comparison (i > 0 always true in loop body)
- Remove unused editorNode variable in SlashCommand onUpdate
- Add type import for ExtendedIntegration
- Fix bare string expressions in test stubs (missing return)
- Remove redundant open={var !== null} in 39 admin modal guards
- Remove redundant null check after early return in health score calc
- Remove redundant open checks in AddTestRunModal useEffect
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ous worker scripts - Standardized console log messages for tenant configuration loading and error handling across multiple worker files. - Enhanced readability by restructuring long lines and ensuring consistent indentation. - Updated error messages to provide clearer context for failures in tenant configuration loading and Elasticsearch operations. This refactor aims to improve code maintainability and clarity without altering functionality.
- Fix session cache not invalidated after user profile update - Fix folder duplicate name error detection for ZenStack error format - Disable submit buttons until async data loads (sessions, milestones, test cases) to prevent race condition with undefined template/workflow - Scope combobox pagination "Next" button selector to avoid wizard button ambiguity in E2E test - Apply prettier formatting to files from main merge Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…session modals - Simplified the connection logic for parent milestones in AddMilestoneModal. - Enhanced the AddSessionModal by using spread operators for conditional connections, improving readability and maintainability. - Added logging for error responses in the API route handler to aid debugging during create/upsert operations. These changes improve code clarity and error tracking without altering existing functionality.
…ous worker scripts - Remove debug console.log statements from automationImports, magic-select-cases, test-results import, aiExportActions, testmoImportWorker, and syncWorker - Remove temporary MODEL API ERROR logging from model handler - Fix pagination E2E tests: navigate directly via URL params (?node=ID&pageSize=10) instead of flaky folder-tree clicks - Fix search-filter pagination tests with same URL param approach Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add missing generate_from_url and generate_from_url_app features to prompt config test data (form validation requires all features to have non-empty systemPrompt) - Switch ACL-06 step creation test from scalar FK to relation connect syntax for ZenStack policy evaluation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…nd testmoImportWorker - Eliminated debug logging related to issue creation and update in syncWorker. - Removed verbose logging for multiple Testmo cases mapping in testmoImportWorker to streamline output and improve code clarity. These changes enhance the maintainability of the worker scripts by reducing clutter in the logs.
- Consolidate AddSessionModal form init into single guarded useEffect with formInitRef to prevent async data loading from wiping user input (fixes "Name must be at least 2 characters" on session create with config+milestone) - Add steps to fast-path create models with indirect project resolution via testCase lookup (bypasses ZenStack policy evaluation bug for deep relation chains during create operations) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
🎉 This PR is included in version 0.21.17 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
clFaster
pushed a commit
to clFaster/testplanit
that referenced
this pull request
Apr 25, 2026
## [0.21.17](TestPlanIt/testplanit@v0.21.16...v0.21.17) (2026-04-16) ### Bug Fixes * resolve E2E failures, CodeQL warnings, and debug cleanup ([TestPlanIt#216](TestPlanIt#216)) ([9d81d8d](TestPlanIt@9d81d8d))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 66 of 70 E2E test failures plus 46 CodeQL quality warnings and removes leftover debug logging.
Changes
CodeQL quality fixes (46 warnings)
E2E root cause fixes
Debug code cleanup
Test plan
Generated with Claude Code