fix(test): validate artifact run id default path#47
Open
Lexiie wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #45.
test artifact get <run-id>used the raw positionalrunIdas the final segment of the default output directory:That made the implicit destination path interpret path-like run IDs as filesystem structure. For example, a value like
../../outsidewould normalize outside the documented.testsprite/runs/artifact root when--outwas omitted.This PR treats
runIdas an opaque identifier for the implicit default path. If callers want a custom filesystem location, the existing explicit--out <dir>path remains the supported mechanism.Changes
resolveDefaultArtifactDir(runId, cwd)for the implicit artifact output directory../../\./.testsprite/runs/<run-id>/.Why
test artifact getwrites a multi-file failure bundle. The documented default path implies containment under.testsprite/runs/, while--outis already available for intentional custom paths. Failing closed on path-like positional IDs keeps the default artifact tree predictable and avoids surprising local writes.Verification
npx vitest run src/commands/test.artifact.spec.tsnpm run typecheck