Cannot set properties on DriveInfoBase objects returned by MockFileSystem.DriveInfo.GetDrives

[jt-msft]

The MockDriveInfo type allows the caller to set various properties on instances of the class (e.g. AvailableFreeSpace or DriveType), but these properties are not included in the objects output by a call to MockFileSystem.DriveInfo.GetDrives() since the array is built from the list of files in the mock without checking if a MockDriveInfo object is defined.

Creating the mock

var fileSystem = new MockFileSystem();
fileSystem.AddFile(@"C:\path\to\file.txt", MockFileData.NullObject);
var driveInfo = new MockDriveInfo(fileSystem, "c:") { DriveType = DriveType.Fixed };

Checking the drive is local

List<string> localDiskDrives = 
(
    from driveInfo in fileSystem.DriveInfo.GetDrives()
    where driveInfo.DriveType == DriveType.Fixed & driveInfo.IsReady
    select driveInfo.RootDirectory.ToString()
).ToList();

Expected
List containing "c:"

Actual
Empty list

[sharpSteff]

I stumbled over this bug, when trying to set AvailableFreeSpace of the MockDriveInfo

// Set some free space
(mockFileSystem.DriveInfo.GetDrives().First() as MockDriveInfo).AvailableFreeSpace = 1024 * 1024;
var availableSpace = (mockFileSystem.DriveInfo.GetDrives().First() as MockDriveInfo).AvailableFreeSpace; 

After setting the AvailableFreeSpace and trying to get AvailableFreeSpace after its '0'

[fgreinacher]

Hm, I wouldn't consider this a bug, but rather a bad API. The properties at MockDriveInfo shouldn't be set-able. Allowing such a feature would force us to somehow maintain the used space so that we could check it against the available space on each write operation.

Other thoughts?

[ThoMAsThe]

I think it's possible if you do it through the constructor directly. Something like this would allow you to set the DriveType:

private class MockDriveInfo : DriveInfoBase { public MockDriveInfo(IFileSystem fileSystem, DriveType driveType) : base(fileSystem) { base.DriveType = driveType; } }

That means you can set the DriveType as such (using Moq for FileSystem):

var mockDriveInfo = new MockDriveInfo(_mockFileSystem.Object, DriveType.Fixed);

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[joeamnesiac]

Is there a solution or workaround for this problem?

[fgreinacher]

Is there a solution or workaround for this problem?

I still have the same opinion as stated in #274 (comment). Does #274 (comment) help?