#187: Directory move shoud be able to move files, not just directories#188
Conversation
…n exception. Implementation note - instead of using System.IO.FileAccess/FileMode, I ended up creating an internal StreamType enum instead to keep the interface simple. That's potentially something to change upon on review, but I think it's good the way it is.
|
Just as a note, I did some conflict resolution locally, and this PR breaks some tests. May need to revisit. |
|
This is for #187 |
|
@AlexanderPruss can you resolve the conflicts so that we see what tests are failing? |
|
@fgreinacher this is probably going to be another case of someone needing to take the PR over. I don't believe the original author is active anymore. |
|
I can try and take a look at this again, but it's been a while and I ended up setting the branch a bit confusingly :X |
|
Um, does this make sense? Can you actually use System.IO.Directory.Move on a file and it works? |
|
It's bit a bit since I've looked at the implementation of this, but all I remember is that it broke a lot of things. To concretely answer your question though, yes, System.IO.Directory.Move on a file will move the file. |
|
I guess in a way it makes sense. A directory or a file is really just a pointer to a structure that either is FileNames in the case of a Directory or FileData in the case of files. While I'm thinking about it, does the inverse work as well? File.Move can move a directory? |
|
Id have to run a test for it, but that would be my assumption as a directory is considered to be a file. |
|
Directory.Move accepts Files though and moves them accordingly |
1 similar comment
|
Directory.Move accepts Files though and moves them accordingly |
|
@AlexanderPruss Can you rebase this on current master? |
|
Closing in favor of #438 |
5 participants
No description provided.