Remove all refs to System.Security.AccessControl from netstandard1.4 version#280
Closed
verybadcat wants to merge 3 commits intoTestableIO:masterfrom
Closed
Remove all refs to System.Security.AccessControl from netstandard1.4 version#280verybadcat wants to merge 3 commits intoTestableIO:masterfrom
verybadcat wants to merge 3 commits intoTestableIO:masterfrom
Conversation
|
TestingHelpers don't work for me on Android without this fix because of #252 (or the related one #272). This looks like possible fix for aforementioned issue. I can confirm that my tests using System.IO.Abstractions.TestingHelpers library started to work after I applied this patch. I used xunit.runner.devices to run my xunit tests inside real Xamarin.Forms app on Android. However, this change breaks backward compatibility. So I tried to solve it in different way and created another Pull Request that avoids such breakage: #289 |
Member
|
I am going to close this PR in favor of #289. Please continue the discussion there as they're both trying to solve the same problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes, this will install in a Xamarin project.
That said, I am not an expert in this area whatsoever. It is possible that I removed the refs from too many environments.