Make package/assembly/directory/project names match#325
Merged
fgreinacher merged 12 commits intoTestableIO:masterfrom Aug 4, 2018
fgreinacher:restructure-projects
Merged
Make package/assembly/directory/project names match#325fgreinacher merged 12 commits intoTestableIO:masterfrom fgreinacher:restructure-projects
fgreinacher merged 12 commits intoTestableIO:masterfrom
fgreinacher:restructure-projects
Conversation
fgreinacher
commented
Jul 14, 2018
| @@ -1,20 +0,0 @@ | |||
| <ProjectConfiguration> | |||
Contributor
Author
There was a problem hiding this comment.
@jpreese @tathamoddie Do you use NCrunch?
Member
There was a problem hiding this comment.
I do, yes. Though I'm not convinced it needs to be in source control.
Contributor
There was a problem hiding this comment.
If we're going to remove these I think it makes sense to update the .gitignore to ensure they don't accidentally work their way back into the repro.
It looks like we already have a section for NCrunch but I don't know why this line didn't cause these files to be ignored:
https://github.com/System-IO-Abstractions/System.IO.Abstractions/blob/e6ec3d48138fbf708c593953b3a395c23f28a84b/.gitignore#L75
Maybe that was updated after these files were already added?
Contributor
Author
There was a problem hiding this comment.
Ah, that’s why Git wants to remove them :)
Add inheritdoc comments to public types Fixes #245 Method comments reference System.IO.FileInfo via inheritdoc tag. * Add XML documentation file (#245) This enables the XML documentation file to be generated for both debug and release configurations. It allows the method comments to be formed into an XML documentation file and distributed alongside System.IO.Abstractions. * Fix incorrect parameter in inheritdoc cref * Add method comments to FileBase (#245) Method comments reference System.IO.File via inheritdoc tag. * Add method comments to PathBase (#245) Method comments reference System.IO.Path via inheritdoc tag. * Add method comments to DriveInfoBase (#245) Method comments reference System.IO.DriveInfo via inheritdoc tag. * Add method comments to FileSystemWatcherBase (#245) Method comments reference System.IO.FileSystemWatcher via inheritdoc tag. * Add class comment to DirectoryInfoBase (#245) Class comment reference System.IO.DirectoryInfo via inheritdoc tag. * Add class comment to FileBase (#245) Class comment reference System.IO.File via inheritdoc tag. * Add class comment to FileInfoBase (#245) Class comment reference System.IO.FileInfo via inheritdoc tag. * Add class comment to FileSystemWatcherBase (#245) Class comment references System.IO.FileSystemWatcher via inheritdoc tag. * Add method comments to FileSystemInfoBase (#245) Method comments reference System.IO.FileSystemInfo via inheritdoc tag. * Add class comment to PathBase (#245) Class comment references System.IO.Path via inheritdoc tag. * Add comments to DirectoryBase (#245) Comments reference System.IO.Directory via inheritdoc tag. * Add method comments to DirectoryInfoBase (#245) Method comments reference System.IO.DirectoryInfo via inheritdoc tag.
* Add FileStreamFactory and support for mocking FileStreams * Fix .NET Standard compile * Adapt MockFileStreamFactory to MockFileStream changes * Add missing ifdefs for MockFileStreamFactory * Use expression bodies * Delete unnecessary nuspec file * Simplify MockFileStreamFactory tests Fixes #224
Setting the XML documentation file through Project Properties/Build only generated the XML documentation file for NET40 and not netstandard1.4 nor netstandard2.0. Adding the property GenerateDocumentationFile and setting it to true generates the documentation for all build types.
This was supported for files before, but directories behave a little differenlty. This should better match .Net System.IO behavior.
* Implement AccessControl on FileInfo. * Addressed code review comments. - Moved namespaces - Fixed SetAccessControl* unit test names
Contributor
Author
|
Any objections on merging this? |
Member
|
This should be OK. As long as we're not making any changes to the namespace we shouldn't be breaking anything. |
Member
|
I think when the conflicts are resolved we're all good 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes package/assembly/directory/project names match.
Fixes #271