Implicit conversion from FileInfo to FileInfoBase#348
Merged
fgreinacher merged 4 commits intoTestableIO:masterfrom Aug 16, 2018
m-ringler:master
Merged
Implicit conversion from FileInfo to FileInfoBase#348fgreinacher merged 4 commits intoTestableIO:masterfrom m-ringler:master
fgreinacher merged 4 commits intoTestableIO:masterfrom
m-ringler:master
Conversation
Contributor
|
Thanks! Please add a test for the new (correct) behavior and we’re good to go! |
Contributor
Author
|
Hm. Where would I add that test? AFAIS there's only a test project for the TestingHelpers...? |
Contributor
|
Yeah, this is currently a bit weird. Just add it to the TestingHelpers test project. |
Added unit test for conversion of null FileInfo to FileInfoBase.
Contributor
Author
|
Here's the requested test. It should fail with an ArgumentNullException on the current System-IO-Abstractions:master. |
Contributor
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #347