Skip to content

Add support for opening a file in Truncate mode#358

Merged
robkeim merged 1 commit intoTestableIO:masterfrom
robkeim:truncate-file-mode
Oct 4, 2018
Merged

Add support for opening a file in Truncate mode#358
robkeim merged 1 commit intoTestableIO:masterfrom
robkeim:truncate-file-mode

Conversation

@robkeim
Copy link
Copy Markdown
Contributor

@robkeim robkeim commented Sep 28, 2018

Fixes #357

@robkeim robkeim mentioned this pull request Sep 28, 2018
Closed
fgreinacher
fgreinacher approved these changes Sep 28, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@fgreinacher fgreinacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@robkeim
Copy link
Copy Markdown
Contributor Author

robkeim commented Oct 1, 2018

Thanks @fgreinacher for the review. @jpreese did you want to review this one as well, or should I go ahead and merge?

@robkeim robkeim merged commit 9694572 into TestableIO:master Oct 4, 2018
@robkeim
Copy link
Copy Markdown
Contributor Author

robkeim commented Oct 4, 2018

I'm going ahead and merging this, I can address any additional comments in a separate PR as necessary.

@robkeim robkeim deleted the truncate-file-mode branch October 4, 2018 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fgreinacher fgreinacher fgreinacher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robkeim @fgreinacher