Throw ArgumentException when path contains invalid characters #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgreinacher
suggested changes
Oct 17, 2018
Contributor
fgreinacher
left a comment
fgreinacher
left a comment
There was a problem hiding this comment.
Thanks! A few minor nits.
| } | ||
|
|
||
| [Test] | ||
| public void MockFileSystem_GetFiles_ThrowsCorrectExceptionForInvalidCharacters() |
Contributor
There was a problem hiding this comment.
I prefer to be specific in the naming, so what about that:
Suggested change
| public void MockFileSystem_GetFiles_ThrowsCorrectExceptionForInvalidCharacters() | |
| public void MockFileSystem_GetFiles_ThrowsArgumentExceptionForInvalidCharacters() |
| fileSystem.AddDirectory(XFS.Path(path)); | ||
|
|
||
| // Act | ||
| TestDelegate wrapped = () => fileSystem.Directory.GetFiles($"{path}{'\0'}.txt"); |
Contributor
There was a problem hiding this comment.
I don't like the name wrapped - maybe something like getFilesWithInvalidCharacterInPath?
| if(path == null) | ||
| if (path == null) | ||
| { | ||
| throw new ArgumentNullException(); |
Contributor
There was a problem hiding this comment.
Please add argument name
|
|
||
| if (path.Any(c => Path.GetInvalidPathChars().Contains(c))) | ||
| { | ||
| throw new ArgumentException(); |
Contributor
There was a problem hiding this comment.
Please add argument name and message.
Contributor
Author
|
Thanks @fgreinacher for the review. I integrated your feedback and pushed a new commit so you should be able to review again. |
Contributor
|
Thanks, looks great now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367