Implement Async File Methods#481
Conversation
Mocks are just passthroughs to sync methods. Async methods are not available in .NET4 or .NET Standard, so added compilation contexts for .NET Core 2.0
|
Thanks for working on this! Glad to merge as soon as CI is happy! |
robkeim
left a comment
robkeim
left a comment
There was a problem hiding this comment.
Thanks for your work on this @Fedoranimus. I've added a couple of comments regarding your implementation. Let me know if you have any questions and I can explain in more detail.
|
This fixes #441, isn't? |
|
@304NotModified correct |
|
Note: This PR doesn't have all of the wrappers implemented - working through that still. |
|
I've implemented all the FileWrappers. Please review and let me know if you have any additional feedback. Thanks! |
|
@Fedoranimus looks like you missed removing the |
robkeim
left a comment
robkeim
left a comment
There was a problem hiding this comment.
Changes look great thanks for doing this @Fedoranimus
|
Great, thanks also from my side! One last thing: Please update the base version in https://github.com/System-IO-Abstractions/System.IO.Abstractions/blob/master/version.json to |
|
@fgreinacher Done. |
|
I noticed ReadAllLinesAsync is not available with .NET Core 3 preview 7, looks like the precompiler condition trips up here. I wanted to ask here before opening an issue, maybe there's something I missed? |
|
Is this a new API of .NET Core 3? If yes, thats fine because we don’t target .NET Core 3 at the moment. If no, it’s a bug. In both cases feel free to open an issue for that. Thanks! |
|
No it's not, I believe the problem is that there's a precompiler #if specifically for netstandard 2.0 |
5 participants
Please give any feedback - this may just be a starting point for implementing async methods.
Mocks are just passthroughs to sync methods.
Async methods are not available in .NET4 or .NET Standard, so added compilation contexts for .NET Core 2.0