Support File.ReadAllLinesAsync and friends on .NET Core 3 / netstandard2.1#502
Merged
fgreinacher merged 8 commits intoTestableIO:masterfrom Sep 26, 2019
Merged
Conversation
Contributor
Author
|
As expected, This means this PR can only be merged if/when the build server supports .NET Core 3. |
Contributor
|
The Ubuntu image seems to have the correct .NET Core SDK now. Windows images don't seem to work yet. Let's just hang on :) |
Adding new methods to our public interfaces is a breaking change for implementors that should be visible to consumers.
Contributor
|
Thanks a lot for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #499, but to do that I added a new netstandard2.1 target. As an example, if you look here, you'll see these async methods were there since netcoreapp2.0 but only available starting with netstandard2.1: https://docs.microsoft.com/en-us/dotnet/api/system.io.file.readallbytesasync?view=netstandard-2.1
I'm not fully sure if this will magically work for the nuget releases, nor if the build server can actually build it (it needs the now-stable preview 8 of .net core 3), but if you want you can merge this after the official .net core 3 release!