Skip to content

Support the FileStream constructor with FileOptions#566

Merged
fgreinacher merged 2 commits intoTestableIO:masterfrom
vladimirlapacek:filestream-fileoptions-constructor
Mar 21, 2020
Merged

Support the FileStream constructor with FileOptions#566
fgreinacher merged 2 commits intoTestableIO:masterfrom
vladimirlapacek:filestream-fileoptions-constructor

Conversation

@vladimirlapacek
Copy link
Copy Markdown
Contributor

Support the FileStream constructor with FileOptions parameter, which is present in implementations, but not in the IFileStreamFactory.

…is present in implementations, but not in the IFileStreamFactory.
@fgreinacher
Copy link
Copy Markdown
Contributor

fgreinacher commented Mar 21, 2020

Cool, thanks! Could you please bump the major in https://github.com/System-IO-Abstractions/System.IO.Abstractions/blob/master/version.json#L3 to indicate this breaking change?

@fgreinacher fgreinacher merged commit 28e5d7d into TestableIO:master Mar 21, 2020
@fgreinacher
Copy link
Copy Markdown
Contributor

Thanks 👍

Jo0 added a commit to Jo0/SmbAbstraction that referenced this pull request Mar 22, 2020
Which adds a missing FileStream constructor to IFileStreamFactory as indicated in this PR

TestableIO/System.IO.Abstractions#566
Jo0 added a commit to jordanlytle/SmbAbstraction that referenced this pull request Mar 22, 2020
Update System.IO.Abstractions to 10.0.1. 

Which adds a missing FileStream constructor to IFileStreamFactory as indicated in this PR 
TestableIO/System.IO.Abstractions#566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants