Skip to content

Fixed #464 #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fgreinacher merged 2 commits into from
Apr 17, 2020
Merged

Fixed #464 #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68436ae
Fixed #464
PeterDowdy Apr 13, 2020
cd90e56
Update System.IO.Abstractions.TestingHelpers/MockFile.cs
fgreinacher Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions System.IO.Abstractions.TestingHelpers.Tests/MockFileReadAllLinesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,22 @@ public void MockFile_ReadAllLines_NotExistingFile_ThrowsCorrectFileNotFoundExcep
Assert.That(exception.Message, Is.EqualTo("Could not find file '" + absentFileNameFullPath + "'."));
}

[Test]
public void MockFile_ReadAllLines_ShouldNotReturnBom()
{
// Arrange
var testFilePath = XFS.Path(@"c:\a test file.txt");
const string testText = "Hello World";
var fileSystem = new MockFileSystem();
fileSystem.File.WriteAllLines(testFilePath, new[] { testText }, Encoding.UTF8);

// Act
var result = fileSystem.File.ReadAllLines(testFilePath, Encoding.UTF8);

// Assert
Assert.That(result.Length, Is.EqualTo(1));
Assert.That(result[0], Is.EqualTo(testText));
}
#if FEATURE_ASYNC_FILE
[Test]
public async Task MockFile_ReadAllLinesAsync_ShouldReturnOriginalTextData()
Expand Down
9 changes: 6 additions & 3 deletions System.IO.Abstractions.TestingHelpers/MockFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,9 +487,12 @@ public override string[] ReadAllLines(string path, Encoding encoding)
}

mockFileDataAccessor.GetFile(path).CheckFileAccess(path, FileAccess.Read);
return encoding
.GetString(mockFileDataAccessor.GetFile(path).Contents)
.SplitLines();

using (var ms = new MemoryStream(mockFileDataAccessor.GetFile(path).Contents))
using (var sr = new StreamReader(ms, encoding))
{
return sr.ReadToEnd().SplitLines();
Comment thread
fgreinacher marked this conversation as resolved.
}
}

public override string ReadAllText(string path)
Expand Down