On Directory.Move, first check to ensure the parent directory for the indicated target folder exists#580
Merged
fgreinacher merged 1 commit intoTestableIO:masterfrom Apr 20, 2020
Conversation
Contributor
Author
|
Let me know if you want me to clean up some of those test cases, it's not very clear specifically what each is uniquely testing. However, they are all unique variations in source/target path segments. |
… indicated target folder exists
pianomanjh
force-pushed
the
bugfix/551-fixup-regression
branch
from
c5ad31a to
1e000cb
Compare
Closed
Contributor
It's fine like that, no worries. Thanks for your endurance on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The solution turns out to be much simpler than I had thought, which is that the target directory structure much exist before copying into a 'new' folder.