Add methods with EnumerationOptions parameter to IDirectoryInfo#641
Merged
fgreinacher merged 4 commits intoTestableIO:mainfrom Sep 28, 2020
sherman89:main
Merged
Add methods with EnumerationOptions parameter to IDirectoryInfo#641fgreinacher merged 4 commits intoTestableIO:mainfrom sherman89:main
fgreinacher merged 4 commits intoTestableIO:mainfrom
sherman89:main
Conversation
Contributor
|
@sherman89 There are some compile errors at the moment. Do you need resolving them? |
Contributor
|
It looks like the abstract functions are not implemented in MockDirectoryInfo.cs(10,18): error CS0534: 'MockDirectoryInfo' does not implement inherited abstract member 'DirectoryInfoBase.GetDirectories(string, EnumerationOptions)' [D:\a\System.IO.Abstractions\System.IO.Abstractions\src\System.IO.Abstractions.TestingHelpers\System.IO.Abstractions.TestingHelpers.csproj]
MockDirectoryInfo.cs(10,18): error CS0534: 'MockDirectoryInfo' does not implement inherited abstract member 'DirectoryInfoBase.EnumerateFiles(string, EnumerationOptions)' [D:\a\System.IO.Abstractions\System.IO.Abstractions\src\System.IO.Abstractions.TestingHelpers\System.IO.Abstractions.TestingHelpers.csproj]
MockDirectoryInfo.cs(10,18): error CS0534: 'MockDirectoryInfo' does not implement inherited abstract member 'DirectoryInfoBase.EnumerateFileSystemInfos(string, EnumerationOptions)' [D:\a\System.IO.Abstractions\System.IO.Abstractions\src\System.IO.Abstractions.TestingHelpers\System.IO.Abstractions.TestingHelpers.csproj]
MockDirectoryInfo.cs(10,18): error CS0534: 'MockDirectoryInfo' does not implement inherited abstract member 'DirectoryInfoBase.GetFileSystemInfos(string, EnumerationOptions)' [D:\a\System.IO.Abstractions\System.IO.Abstractions\src\System.IO.Abstractions.TestingHelpers\System.IO.Abstractions.TestingHelpers.csproj]
MockDirectoryInfo.cs(10,18): error CS0534: 'MockDirectoryInfo' does not implement inherited abstract member 'DirectoryInfoBase.EnumerateDirectories(string, EnumerationOptions)' [D:\a\System.IO.Abstractions\System.IO.Abstractions\src\System.IO.Abstractions.TestingHelpers\System.IO.Abstractions.TestingHelpers.csproj]
MockDirectoryInfo.cs(10,18): error CS0534: 'MockDirectoryInfo' does not implement inherited abstract member 'DirectoryInfoBase.GetFiles(string, EnumerationOptions)' [D:\a\System.IO.Abstractions\System.IO.Abstractions\src\System.IO.Abstractions.TestingHelpers\System.IO.Abstractions.TestingHelpers.csproj] |
Contributor
Author
|
@fgreinacher @P-Storm Oops sorry about that! Fixed it now :) CI errors seemed not my fault and didn't notice build status anywhere. Hope the PR is ok now... |
Contributor
No worries, thank you!
Seems like .NET Install action has introduced some breaking changes with https://github.com/actions/setup-dotnet/releases/tag/v1.7.0. I'll take care of this! |
Contributor
|
#646 fixes the CI issues. |
Contributor
|
I bumped the minor part of the version with 6ac5b67 to reflect this new feature. |
Contributor
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In .NET Standard 2.1, new method overloads were introduced to DirectoryInfo that take in an EnumerationOptions as a parameter. This PR adds those.
Fixes #593