EnumerationOptions With recursion#652
Merged
fgreinacher merged 1 commit intoTestableIO:mainfrom Oct 12, 2020
P-Storm:EnumerationOptions-simplefix
Merged
EnumerationOptions With recursion#652fgreinacher merged 1 commit intoTestableIO:mainfrom P-Storm:EnumerationOptions-simplefix
fgreinacher merged 1 commit intoTestableIO:mainfrom
P-Storm:EnumerationOptions-simplefix
Conversation
This was referenced Oct 9, 2020
Contributor
|
Great finding, thanks a lot! Also for the additional issues! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #651
It looks like the code is not checking the
EnumerationOptions.RecurseSubdirectories.This fixes my problem with the recursion, but I see more problems in the future with the following settings in:
Will creating a seperate issue for these.