Skip to content

feat: add IPath.GetFullPath(string,string) #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fgreinacher merged 2 commits into from
Oct 15, 2020
Merged

feat: add IPath.GetFullPath(string,string) #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2f2319
adds getfullpath overload
Oct 14, 2020
68306e3
changes according to review
Oct 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/System.IO.Abstractions/IPath.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ public interface IPath
string GetFileNameWithoutExtension(string path);
/// <inheritdoc cref="Path.GetFullPath(string)"/>
string GetFullPath(string path);
#if FEATURE_ADVANCED_PATH_OPERATIONS
/// <inheritdoc cref="Path.GetFullPath(string, string)"/>
string GetFullPath(string path, string basePath);
#endif
/// <inheritdoc cref="Path.GetInvalidFileNameChars"/>
char[] GetInvalidFileNameChars();
/// <inheritdoc cref="Path.GetInvalidPathChars"/>
Expand Down
5 changes: 5 additions & 0 deletions src/System.IO.Abstractions/PathBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ internal PathBase() { }
/// <inheritdoc cref="Path.GetFullPath(string)"/>
public abstract string GetFullPath(string path);

#if FEATURE_ADVANCED_PATH_OPERATIONS
/// <inheritdoc cref="Path.GetFullPath(string, string)"/>
public abstract string GetFullPath(string path, string basePath);
#endif

/// <inheritdoc cref="Path.GetInvalidFileNameChars"/>
public abstract char[] GetInvalidFileNameChars();

Expand Down
7 changes: 7 additions & 0 deletions src/System.IO.Abstractions/PathWrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,13 @@ public override string GetFullPath(string path)
return Path.GetFullPath(path);
}

# if FEATURE_ADVANCED_PATH_OPERATIONS
public override string GetFullPath(string path, string basePath)
{
return Path.GetFullPath(path, basePath);
}
#endif

public override char[] GetInvalidFileNameChars()
{
return Path.GetInvalidFileNameChars();
Expand Down