Skip to content

chore: add icon for NuGet packages#742

Merged
fgreinacher merged 5 commits intoTestableIO:mainfrom
soi013:patch-1
Jul 27, 2021
Merged

chore: add icon for NuGet packages#742
fgreinacher merged 5 commits intoTestableIO:mainfrom
soi013:patch-1

Conversation

@soi013
Copy link
Copy Markdown
Contributor

@soi013 soi013 commented Jul 20, 2021

It would be better to have an icon when searching for nuget.

image

Icon url was copied from "System.IO.Abstractions.Analyzers.csproj".

https://github.com/System-IO-Abstractions/System.IO.Abstractions.Analyzers/blob/develop/System.IO.Abstractions.Analyzers/System.IO.Abstractions.Analyzers.csproj

@soi013 soi013 changed the title Add PackageIcon for nuget feat: Add PackageIcon for nuget Jul 20, 2021
@fgreinacher fgreinacher changed the title feat: Add PackageIcon for nuget feat: add icon for NuGet packages Jul 23, 2021
@soi013
Copy link
Copy Markdown
Contributor Author

soi013 commented Jul 23, 2021

OK. I will change it in two days after tomorrow.

@fgreinacher fgreinacher changed the title feat: add icon for NuGet packages chore: add icon for NuGet packages Jul 24, 2021
@soi013
Copy link
Copy Markdown
Contributor Author

soi013 commented Jul 26, 2021

Can I add the icon in the solution folder?
ex) /System.IO.Abstractions/System.IO.Abstractions_Icon_256x256.png

https://avatars1.githubusercontent.com/u/40829877

Is this logo image copyrighted by the System.IO.Abstractions project?

Because, PackageIcon needs folder-based source.

https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets#packageicon

Visual Studio supports PackageIcon for packages coming from a folder-based source.

@fgreinacher
Copy link
Copy Markdown
Contributor

Thanks for driving this forward!

Can I add the icon in the solution folder?
ex) /System.IO.Abstractions/System.IO.Abstractions_Icon_256x256.png

Yes, please put it to ./images/icon_256x256.png.

Is this logo image copyrighted by the System.IO.Abstractions project?

Yes, it's from the Arabia IO pack that is free for personal use (see #324).

@fgreinacher fgreinacher enabled auto-merge (squash) July 27, 2021 20:10
@fgreinacher
Copy link
Copy Markdown
Contributor

Thanks a lot 👍

@fgreinacher fgreinacher merged commit 1bd2382 into TestableIO:main Jul 27, 2021
@github-actions
Copy link
Copy Markdown

This is addressed in release v13.2.43.

@github-actions github-actions Bot added the state: released Issues that are released label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state: released Issues that are released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants