You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request adds important test coverage for edge cases in the MockRegistry property setup and access logic, ensuring correct behavior when using the optimized member-id lookup paths. It also adds comments clarifying why certain mutation testing suppressions are safe. The changes improve the reliability of the property setup resolution and document subtle implementation details.
Test coverage improvements:
Added a test to ensure that when the member-id table contains a null entry, GetPropertyFast correctly falls back to the slower path without throwing an exception.
Added a test to verify that when both a member-id-based and a dictionary-based property setup exist for the same property, SetPropertyFast uses the member-id setup in the default scope.
Added a test to ensure that when a scenario is active, SetPropertyFast routes to the scenario-specific setup instead of the member-id table setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coverageAdditional tests for edge cases or improvement of test coveragestate: releasedThe issue is released
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds important test coverage for edge cases in the
MockRegistryproperty setup and access logic, ensuring correct behavior when using the optimized member-id lookup paths. It also adds comments clarifying why certain mutation testing suppressions are safe. The changes improve the reliability of the property setup resolution and document subtle implementation details.Test coverage improvements:
nullentry,GetPropertyFastcorrectly falls back to the slower path without throwing an exception.SetPropertyFastuses the member-id setup in the default scope.SetPropertyFastroutes to the scenario-specific setup instead of the member-id table setup.