Skip to content

perf: pre-size setup dispatch tables to FastMockInteractions member count #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbreuss merged 2 commits into from
May 11, 2026
Merged

perf: pre-size setup dispatch tables to FastMockInteractions member count #773

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
930b3d9
perf: pre-size setup dispatch tables to FastMockInteractions member c…
vbreuss May 11, 2026
b3be8a2
Potential fix for pull request finding
vbreuss May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions Source/Mockolate/MockRegistry.Setup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System;
using System.Diagnostics;
using System.Threading;
using Mockolate.Interactions;
using Mockolate.Setup;

namespace Mockolate;
Expand All @@ -10,6 +11,14 @@ public partial class MockRegistry
[DebuggerBrowsable(DebuggerBrowsableState.Never)]
private readonly object _setupsByMemberIdLock = new();

/// <summary>
/// Returns the generator-known member count hint when <see cref="Interactions" /> is a
/// <see cref="FastMockInteractions" />, so dispatch tables can be sized once on first allocation
/// instead of growing one slot at a time as setups for higher-numbered members come in.
/// </summary>
private int GetMemberCountHint()
=> Interactions is FastMockInteractions fast ? fast.Buffers.Length : 0;

[DebuggerBrowsable(DebuggerBrowsableState.Never)]
private EventSetup[]?[]? _eventSetupsByMemberId;

Expand Down Expand Up @@ -84,7 +93,7 @@ private void AppendToIndexerMemberIdBucket(int memberId, IndexerSetup indexerSet
IndexerSetup[]?[]? oldTable = _indexerSetupsByMemberId;
int requiredLen = memberId + 1;
// Stryker disable once Conditional : when oldTable is not null and requiredLen <= oldTable.Length, the resize-condition below is false either way and the else-branch reuses oldTable; newLen is unread, so collapsing the ternary to requiredLen is observationally identical.
int newLen = oldTable is null ? requiredLen : Math.Max(oldTable.Length, requiredLen);
int newLen = oldTable is null ? Math.Max(requiredLen, GetMemberCountHint()) : Math.Max(oldTable.Length, requiredLen);
IndexerSetup[]?[] newTable;
// Stryker disable once Equality : flipping > to >= only fires the realloc-and-copy path when newLen == oldTable.Length, producing a fresh table with identical contents — externally indistinguishable from reusing oldTable.
if (oldTable is null || newLen > oldTable.Length)
Expand Down Expand Up @@ -180,7 +189,7 @@ private void AppendToMemberIdBucket(int memberId, MethodSetup methodSetup)
MethodSetup[]?[]? oldTable = _setupsByMemberId;
int requiredLen = memberId + 1;
// Stryker disable once Conditional : when oldTable is not null and requiredLen <= oldTable.Length, the resize-condition below is false either way and the else-branch reuses oldTable; newLen is unread, so collapsing the ternary to requiredLen is observationally identical.
int newLen = oldTable is null ? requiredLen : Math.Max(oldTable.Length, requiredLen);
int newLen = oldTable is null ? Math.Max(requiredLen, GetMemberCountHint()) : Math.Max(oldTable.Length, requiredLen);
MethodSetup[]?[] newTable;
// Stryker disable once Equality : flipping > to >= only fires the realloc-and-copy path when newLen == oldTable.Length, producing a fresh table with identical contents — externally indistinguishable from reusing oldTable.
if (oldTable is null || newLen > oldTable.Length)
Expand Down Expand Up @@ -275,7 +284,7 @@ private void PublishPropertyToMemberIdBucket(int memberId, PropertySetup propert
PropertySetup?[]? oldTable = _propertySetupsByMemberId;
int requiredLen = memberId + 1;
// Stryker disable once Conditional : when oldTable is not null and requiredLen <= oldTable.Length, the resize-condition below is false either way and the else-branch reuses oldTable; newLen is unread, so collapsing the ternary to requiredLen is observationally identical.
int newLen = oldTable is null ? requiredLen : Math.Max(oldTable.Length, requiredLen);
int newLen = oldTable is null ? Math.Max(requiredLen, GetMemberCountHint()) : Math.Max(oldTable.Length, requiredLen);
PropertySetup?[] newTable;
// Stryker disable once Equality : flipping > to >= only fires the realloc-and-copy path when newLen == oldTable.Length, producing a fresh table with identical contents — externally indistinguishable from reusing oldTable.
if (oldTable is null || newLen > oldTable.Length)
Expand Down Expand Up @@ -365,7 +374,7 @@ private void AppendToEventMemberIdBucket(int memberId, EventSetup eventSetup)
EventSetup[]?[]? oldTable = _eventSetupsByMemberId;
int requiredLen = memberId + 1;
// Stryker disable once Conditional : when oldTable is not null and requiredLen <= oldTable.Length, the resize-condition below is false either way and the else-branch reuses oldTable; newLen is unread, so collapsing the ternary to requiredLen is observationally identical.
int newLen = oldTable is null ? requiredLen : Math.Max(oldTable.Length, requiredLen);
int newLen = oldTable is null ? Math.Max(requiredLen, GetMemberCountHint()) : Math.Max(oldTable.Length, requiredLen);
EventSetup[]?[] newTable;
// Stryker disable once Equality : flipping > to >= only fires the realloc-and-copy path when newLen == oldTable.Length, producing a fresh table with identical contents — externally indistinguishable from reusing oldTable.
if (oldTable is null || newLen > oldTable.Length)
Expand Down
Loading