feat: Phase 5.3 step 1 - flag MockFileSystem.MockTime for manual review#15
Merged
Conversation
TestableIO's `fs.MockTime(Func<DateTime>)` is invoked on every timestamp request. Testably's equivalent (`o => o.UseTimeSystem(new MockTimeSystem(...))`) takes a fixed initial time + mutable advance API and lives only inside the construction-time options lambda. The two have no observably-equivalent automatic rewrite for arbitrary delegates. Ship the analyzer side now: pattern id `MockFileSystem.MockTime`, code-fix dispatcher silently falls through. The cross-statement fold for the narrow constant-DateTime lambda shape needs a custom FixAllProvider (the rewrite touches the construction expression that the parameterless / options ctor fixes also touch — BatchFixer races) and is deferred to a follow-up.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestableIO's
fs.MockTime(Func<DateTime>)is invoked on every timestamp request. Testably's equivalent (o => o.UseTimeSystem(new MockTimeSystem(...))) takes a fixed initial time + mutable advance API and lives only inside the construction-time options lambda. The two have no observably-equivalent automatic rewrite for arbitrary delegates.Ship the analyzer side now: pattern id
MockFileSystem.MockTime, code-fix dispatcher silently falls through. The cross-statement fold for the narrow constant-DateTime lambda shape needs a custom FixAllProvider (the rewrite touches the construction expression that the parameterless / options ctor fixes also touch — BatchFixer races) and is deferred to a follow-up.