test: consider settings for skipping tests against real file system#949
Merged
test: consider settings for skipping tests against real file system#949
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a test settings mechanism to conditionally skip tests that interact with the real file system in the Testably.Abstractions.Testing.Tests project. This allows developers to control whether these tests run based on configuration settings, similar to the pattern already used for brittle and long-running tests in the generated test classes.
Changes:
- Added a collection fixture to enable test settings for real file system tests
- Updated
FileSystemInitializerExtensionsTeststo use the fixture and conditionally skip tests that interact with the real file system - Implemented a skip helper method with DEBUG/RELEASE mode-specific logic
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Tests/Testably.Abstractions.Testing.Tests/TestHelpers/FileSystemTestSettingsFixture.cs | Defines the xUnit collection fixture for the "RealFileSystemTests" collection, enabling TestSettingsFixture injection |
| Tests/Testably.Abstractions.Testing.Tests/FileSystemInitializerExtensionsTests.cs | Adds collection attribute, constructor parameter injection, skip helper method, and skip calls to tests that interact with the real file system |
Tests/Testably.Abstractions.Testing.Tests/FileSystemInitializerExtensionsTests.cs
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies the test settings mechanism to conditionally skip tests that interact with the real file system in the
Testably.Abstractions.Testing.Testsproject. This allows developers to control whether these tests run based on configuration settings, similar to the pattern already used for brittle and long-running tests in the generated test classes.