Fix adjacent tag matching in ReprHighlighter#4147
Open
mariettakyriazi wants to merge 1 commit into
Open
Conversation
mariettakyriazi
force-pushed
the
fix-repr-highlighter-tags-4035
branch
from
ab84910 to
3bd56b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4035
This PR fixes adjacent tag matching in ReprHighlighter.
Previously, the regex used a greedy match for tag contents, causing adjacent tags such as:
content1content2
to be merged into a single match.
The regex has been updated to correctly handle adjacent tags while preserving existing behavior.
Changes:
Testing:
python -m pytest tests/test_highlighter.py
Result:
84 tests passed.