Skip to content

Add Python 3.11 to CI, update install-poetry action #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 31, 2022
Merged

Add Python 3.11 to CI, update install-poetry action #1016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91b2e03
Add Python 3.11 to CI, update install-poetry action
darrenburns Oct 25, 2022
7599acc
Fix GitHub action install-poetry version
darrenburns Oct 25, 2022
5933cbb
Revert build action to 3.11-rc.2 until Darwin build ready
darrenburns Oct 25, 2022
ceed918
Python 3.11 CI
darrenburns Oct 27, 2022
8f888e7
Add small delay before screenshot is taken
darrenburns Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/pythonpackage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ["3.7", "3.8", "3.9", "3.10"]
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"]
defaults:
run:
shell: bash
Expand All @@ -20,9 +20,9 @@ jobs:
python-version: ${{ matrix.python-version }}
architecture: x64
- name: Install and configure Poetry
uses: snok/install-poetry@v1.1.6
uses: snok/install-poetry@v1.3.3
with:
version: 1.1.6
version: 1.2.2
virtualenvs-in-project: true
- name: Install dependencies
run: poetry install --extras "dev"
Expand Down
1 change: 1 addition & 0 deletions src/textual/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,6 +641,7 @@ async def press_keys() -> None:
await asyncio.sleep(0.02)

await app._animator.wait_for_idle()
await asyncio.sleep(0.05)
Copy link
Member Author

@darrenburns darrenburns Oct 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows, screenshots seemed to be slightly too early and the final key wasn't being processed. Not ideal of course, but seems to fix the issue.

Copy link
Member

@willmcgugan willmcgugan Oct 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THis might be redundant with a pending PR.


if screenshot:
self._screenshot = self.export_screenshot(
Expand Down