Add 2022 year in review blog post #1415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO @darrenburns : Link to rich-pixels - mentioned library but not linked to it or said name of it. |
darrenburns
commented
Dec 21, 2022
| @@ -0,0 +1,171 @@ | |||
| --- | |||
| draft: true | |||
There was a problem hiding this comment.
Have left this as a draft for now.
darrenburns
commented
Dec 21, 2022
Comment on lines
+64
to
+68
| Textual forgoes the z-index concept from browser CSS and instead uses a “named layer” system. Using the `layers` property you can defined an ordered list of named layers, and using the `layer` property, you can assign a descendant widget to one of those layers. | ||
|
|
||
| By creating a new layer above all others and assigning a widget to that layer, we can ensure that widget is painted above everything else. | ||
|
|
||
| In order to determine where to place the dropdown, we can track the current value in the dropdown by `watch`ing the reactive input “value” inside the Input widget. This method will be called every time the `value` of the Input changes, and we can use this hook to amend the position of our dropdown position to accommodate for the length of the input value. |
There was a problem hiding this comment.
I feel this part might be a bit jarring - I randomly start going into a bit too much implementation detail. Maybe I should talk a bit more about Shira and the functionality of the autocomplete library at a high level instead.
There was a problem hiding this comment.
Think I'll be publishing on Sunday. I think this is great, but feel free to PR edits before then if you like.
There was a problem hiding this comment.
@willmcgugan Should I set draft: false now or will you do it?
willmcgugan
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.