Allow App.dark to be set as early as App.on_load
#1421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses Textualize#1369 by swallowing any `ScreenStackError` when calling `refresh_css` after setting the -{dark,light}-mode class on the app. The idea here being that if there is no screen, that's fine, the style will be taken up once there is one.
Member
|
Can we have a regression test that sets |
Contributor
Author
Added. |
willmcgugan
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1369 by swallowing any
ScreenStackErrorwhen attempting to update the styles withinApp.watch_dark; the idea being that if there isn't a screen, one will be coming soon, and the styles will get taken up then anyway.