adds Strip primitive #1444
Merged
adds Strip primitive #1444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimelessP
reviewed
Dec 29, 2022
| self._head = [] | ||
| self._cache.clear() | ||
| self._full = False | ||
| self._head = [] |
There was a problem hiding this comment.
Should it also clear hits and misses counts?
Member
Author
There was a problem hiding this comment.
The hits and misses are a debugging aid to see how well the cache is performing. You generally want to know about past performance even when it is cleared.
Member
Author
|
@darrenburns @davep @rodrigogiraoserrao Merging this. You might want to do a retroactive review at some point. #executivedecision |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stripprimitive which represents a line worth of segments.hitsandmissesattributes to LRUCachetextual._cache.FIFOCacheBecause Strip is immutable this allows for caching that wouldn't otherwise have been possible. Not all these optimizations have been fully realized yet