perf: use deque for lazy widget reveal queue#6398
Closed
giulio-leone wants to merge 1 commit intoTextualize:mainfrom
Closed
perf: use deque for lazy widget reveal queue#6398giulio-leone wants to merge 1 commit intoTextualize:mainfrom
giulio-leone wants to merge 1 commit intoTextualize:mainfrom
Conversation
Lazy widgets are mounted one-at-a-time via a timer callback that calls .pop(0) on each tick. Each .pop(0) is O(n); switching to collections.deque with .popleft() gives O(1) front removal. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
list.pop(0)withcollections.deque.popleft()in the lazy-widget reveal timer callback.Problem
Lazy._reveal()drains the pending-widgets list one element at a time via a recurring timer. Eachlist.pop(0)call is O(n) because CPython must shift all remaining elements left.Solution
Switch
_widgetsfromlist[Widget]tocollections.deque[Widget]and use.popleft()for O(1) front removal.Compatibility
.append(),.copy(),.clear(), truthiness, and iteration are identical ondequeComplexity