fix: bounds-check start_line in Selection.extract()#6433
Closed
Jah-yee wants to merge 1 commit intoTextualize:mainfrom
Closed
fix: bounds-check start_line in Selection.extract()#6433Jah-yee wants to merge 1 commit intoTextualize:mainfrom
Jah-yee wants to merge 1 commit intoTextualize:mainfrom
Conversation
When Selection.extract() is called with coordinates that exceed the text line count, it crashes with IndexError. This happens because end_line is bounds-checked but start_line is not. Fix: Add bounds check for start_line similar to end_line to prevent IndexError when start_line exceeds the text line count. Fixes Textualize#6428
Collaborator
|
More AI spam - see #6434 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Selection.extract() is called with coordinates that exceed the
text line count, it crashes with IndexError. This happens because
end_line is bounds-checked but start_line is not.
Fix: Add bounds check for start_line similar to end_line to prevent
IndexError when start_line exceeds the text line count.
Fixes #6428