Skip to content

adding react native example, and reorganizing sdk directories#12

Merged
daxfrost merged 2 commits intomainfrom
react-native-example
Apr 10, 2024
Merged

adding react native example, and reorganizing sdk directories#12
daxfrost merged 2 commits intomainfrom
react-native-example

Conversation

@daxfrost
Copy link
Copy Markdown
Contributor

@daxfrost daxfrost commented Apr 10, 2024

@daxfrost daxfrost requested a review from a team April 10, 2024 17:40
@daxfrost daxfrost self-assigned this Apr 10, 2024
@daxfrost daxfrost requested review from slava-ovchinnikov and removed request for a team April 10, 2024 17:40
@daxfrost daxfrost marked this pull request as ready for review April 10, 2024 17:40
@daxfrost daxfrost requested review from a team, cjunginger, jeshud, rcasto, slava-ovchinnikov and victorquinn and removed request for a team, cjunginger, jeshud and slava-ovchinnikov April 10, 2024 17:40
Copy link
Copy Markdown
Member

@victorquinn victorquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐰

Copy link
Copy Markdown
Contributor

@rcasto rcasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments, but looks good! :shipit:

Comment thread connect/sdk/javascript/.env.example
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Know a lot of these are generated or come boiller plate with the expo app start, not sure if we'd want to use some Texture logos and theme colors here at some point to pretty these up a bit haha

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe I thought the same, but on the other hand I feel it's more clear to developers this is a vanilla project if we don't.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a biggie, but for the other examples we are using yarn, might wanna consolidate these to one or the other

@daxfrost daxfrost merged commit 73ae09c into main Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants