Skip to content

Cast data size to unsigned int#405

Merged
prince-chrismc merged 7 commits intoThalhammer:masterfrom
JurgenLB:JurgenLB-patch-2
Feb 9, 2026
Merged

Cast data size to unsigned int#405
prince-chrismc merged 7 commits intoThalhammer:masterfrom
JurgenLB:JurgenLB-patch-2

Conversation

@JurgenLB
Copy link
Contributor

@JurgenLB JurgenLB commented Feb 7, 2026

this is to address some additional warnings for the type conversion.

4 EVP_DigestUpdate warnings (lines 1627, 1667, 1987, 2036):
static_cast(data.size())
to explicitly convert size_t (__int64 on 64-bit Windows) to unsigned int

1 time conversion warning (line 2673):
static_cast<int64_t>(std::llround(as_number()))
to explicitly handle the conversion from long long to int64_t

These conversions are safe because JWT data is always small (< 4GB) or have the same range

kind regards

@prince-chrismc
Copy link
Collaborator

There's source files missing in the coverage report but working it better than not. No idea if they are tested correctly.

@JurgenLB
Copy link
Contributor Author

JurgenLB commented Feb 8, 2026

If you want I can separate the coverage report and the type conversions.

Why the coverage reports was not working I do not know.
For this to pass I only added LCOV_ARGS "--ignore-errors;mismatch;--ignore-errors;unused")

Kind regards

@prince-chrismc
Copy link
Collaborator

There was previously a abi issue with the github actuation runner image mixing gcc llvm and lcov from different sources.

Haven't checked recently 🙀

We've gotten a few emails for a new release so I will cut a new one and merge in a few PRs today

@prince-chrismc prince-chrismc merged commit 0b4fece into Thalhammer:master Feb 9, 2026
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants