Support Ed25519 for LibreSSL 3.7.1+#407
Merged
prince-chrismc merged 2 commits intoThalhammer:masterfrom Feb 17, 2026
Merged
Conversation
b3b05d2 to
42c2cbd
Compare
Collaborator
|
Very interesting, it seems like a bit of an over site we disabled the tests but not the API... I dont like breaking changes but removing something that doesn't work seems reasonable.... |
42c2cbd to
9e3b821
Compare
prince-chrismc
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LibreSSL added support for Ed25519 in Version 3.7.1
Therefore I include LibreSSL >= 3.7.1 for the EdDSA implementation. I simplified the conditions because it uses the same oneshot EVP_DigestSign and EVP_DigestVerify just as OpenSSL 1.1.1 does.
The previous special case for LibreSSL was actually never needed in the first place, because LibreSSL never did compile EdDSA. Therefore we also do not need to consider older versions compatibility for the EdDSA bit.
All tests run through on version 4.2.1.