feat: Support AttachedTo metadata for policies and update Basic Rate Limit #1
Conversation
- Updated SDK PolicyMetadata to include AttachedTo field
- Updated Gateway Controller to inject AttachedTo parameter ("api" or "route") during policy conversion
- Updated Policy Engine to extract AttachedTo from parameters and set it in PolicyMetadata
- Updated Basic Rate Limit policy to use "apiname" key extractor when AttachedTo is "api"
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Updated SDK PolicyMetadata to include AttachedTo field
- Updated Gateway Controller to inject AttachedTo parameter ("api" or "route") during policy conversion
- Updated Policy Engine to extract AttachedTo from parameters and set it in PolicyMetadata
- Updated Basic Rate Limit policy to use "apiname" key extractor when AttachedTo is "api"
- Updated integration tests to verify new behavior and fix regressions caused by scoping changes
- Merged latest changes from ratelimit-latest. - Updated `gateway/it/features/basic-ratelimit.feature` to align with the new rate limiting behavior: - API-level attachment now implies a shared bucket (per API). - Route-level attachment (per operation) implies independent buckets. - Adjusted test expectations and configurations accordingly. - Verified that all integration tests pass.
- Merged latest changes from ratelimit-latest. - Updated `gateway/it/features/basic-ratelimit.feature` to align with the new rate limiting behavior: - API-level attachment now implies a shared bucket (per API). - Route-level attachment (per operation) implies independent buckets. - Adjusted test expectations and configurations accordingly. - Verified that all integration tests pass.
This PR implements the logic to distinguish between policies attached at the API level versus the Resource/Route level.
Key changes:
AttachedTofield toPolicyMetadatainsdk/gateway/policy/v1alpha/interface.go.handlers.goandmain.goto pass "api" or "route" as context when converting policies, injecting this value into the policy parameters.handler.goto extract theattachedToparameter and populate thePolicyMetadata.basic_ratelimit.goto checkmetadata.AttachedTo. If it is "api", the rate limit key extractor is set toapiname, otherwise it defaults toroutename.This ensures that API-level rate limits are applied correctly using the API name as the key, while Route-level rate limits continue to use the Route name.
PR created automatically by Jules for task 11151761427082548090 started by @Tharsanan1