FragmentCuller stops working with FragmentHighlighter

[vulevukusej]

Describe the bug 📝

In my testing it appears that the fragmentCuller doesn't work for meshes created by the fragmentHighlighter. In the example below, I've called the highlightById function on the FragmentIdMap associated with each storey in the model. While this works, the performance takes quite a hit and I noticed that none of the objects were being culled when out of view.

After calling the function I set needsUpdate on the culler to true. Any tips on how to circumvent this?

Reproduction ▶️

No response

Steps to reproduce 🔢

No response

System Info 💻

version: 1.1.4

Used Package Manager 📦

npm

Error Trace/Logs 📃

No response

Validations ✅

• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a IFC.js components issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
• Check that this is a concrete bug. For Q&A join our Community.
• The provided reproduction is a minimal reproducible example of the bug.

[vulevukusej]

Could this line be the issue: ?
https://github.com/IFCjs/components/blob/54f63c4a0daee442110533c5f364cf3787219c37/src/fragments/FragmentHighlighter/index.ts#L427C15-L427C15

[vulevukusej]

I believe the issue lies in the way the fragment highlighter works. It creates a mesh for each object which isn't automatically added to the fragment culler. I tried to modify this behaviour by adding the new meshes to the fragment culler and this actually solved the issue initially. However, this introduced weird behaviour when deactivating the highlighter: some meshes were invisible afterwards.

[RyugaRyuzaki]

I believe the issue lies in the way the fragment highlighter works. It creates a mesh for each object which isn't automatically added to the fragment culler. I tried to modify this behaviour by adding the new meshes to the fragment culler and this actually solved the issue initially. However, this introduced weird behaviour when deactivating the highlighter: some meshes were invisible afterwards.

I figured out some different. If i install via npm package it got some issue, however i download this file https://github.com/IFCjs/components/blob/main/resources/openbim-components.js , issue is gone. or event i use server side rendering is OK.

[agviegas]

Hum 🤔 I understand that you are using the FragmentHighlighter as a way to recolorize the meshes. If we provided a component to recolorize without using the highlighter, would this solve your use case @vulevukusej?

[vulevukusej]

@agviegas you read my mind. That's exactly what I want. I think it'd be relevant for a lot of use cases, think scheduling, issues, version comparison, cost analysis etc. Let me know if I can help as well 👌

[HoyosJuan]

Hey @vulevukusej! I did two things here:

1. I have added a configuration in the highlighter to decide if the highlight meshes are added to the culler or not. By default, is true. This was merged by PR fix(components): Fragment highlighter meshes added to ScreenCuller #238.
2. Feature issue MaterialManager selection similar to "highlightByID" #226 already proposes to colorize fragment meshes just as you mentioned above. So, I will close this issue here and hopefully implement the feature asap.

Thanks!

[vulevukusej]

@HoyosJuan awesome stuff! Happy holidays 😊