Skip to content

fix(camera): deep zooming velocity with dynamicAnchor - #769

Merged
agviegas merged 1 commit into
ThatOpen:mainfrom
ShaMan123:fix/camera-zoom-decay
Jul 24, 2026
Merged

fix(camera): deep zooming velocity with dynamicAnchor#769
agviegas merged 1 commit into
ThatOpen:mainfrom
ShaMan123:fix/camera-zoom-decay

Conversation

@ShaMan123

@ShaMan123 ShaMan123 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Description

Zooming is expected to be an exponential operand derived by the wheel event.
Currently, when setting dynamicAnchor = true zooming decays very quickly until it barely moves.
Rotating the camera restores some zoom ability.
This PR fixes the root cause (camera controls minDistance set by dynamicAnchor logic).
I wonder if setting minDistance is really needed. Kept it for safety. If not let's remove it.
This fix is partial - it restores the ability to zoom in depth, but it does not fix zooming to the expected behavior. That is a different fix and is unrelated/invariant to dynamicAnchor.
related #770

Before

Screen.Recording.2026-07-21.at.10.19.58.mov

After

Screen.Recording.2026-07-21.at.10.16.06.mov

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ShaMan123 ShaMan123 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zoom still doesn't behave as expected - it becomes linear.
Tracked in #770

@ShaMan123 ShaMan123 changed the title fix(camera): zoom decay fix(camera): deep zooing Jul 21, 2026
@ShaMan123 ShaMan123 changed the title fix(camera): deep zooing fix(camera): deep zooing velocity Jul 21, 2026
@ShaMan123 ShaMan123 changed the title fix(camera): deep zooing velocity fix(camera): deep zooing velocity with dynamicAnchor Jul 21, 2026
@ShaMan123

Copy link
Copy Markdown
Contributor Author

Can this be published soon? It is a vital fix for my app

@ShaMan123 ShaMan123 changed the title fix(camera): deep zooing velocity with dynamicAnchor fix(camera): deep zooming velocity with dynamicAnchor Jul 21, 2026
@agviegas

Copy link
Copy Markdown
Contributor

Thanks for the fix. Today I'm publishing all fixed issues and commited prs in fragments and components (they are many). Afterwards I'll merge this and publish again

@ShaMan123
ShaMan123 force-pushed the fix/camera-zoom-decay branch from e393a4d to f75d4b1 Compare July 24, 2026 16:17
@agviegas
agviegas merged commit 5c2dd9d into ThatOpen:main Jul 24, 2026
@agviegas agviegas mentioned this pull request Jul 24, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants