Skip to content

fix(components): 224 - QuerySelector failing on SimpleUICard#228

Merged
HoyosJuan merged 2 commits intoThatOpen:mainfrom
HoyosJuan:224-queryselector-failing
Dec 21, 2023
Merged

fix(components): 224 - QuerySelector failing on SimpleUICard#228
HoyosJuan merged 2 commits intoThatOpen:mainfrom
HoyosJuan:224-queryselector-failing

Conversation

@HoyosJuan
Copy link
Copy Markdown
Member

Description

This PR solves issue #224.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@HoyosJuan HoyosJuan merged commit d797b0d into ThatOpen:main Dec 21, 2023
@HoyosJuan HoyosJuan deleted the 224-queryselector-failing branch December 21, 2023 15:55
development-ac pushed a commit to Active-Collective/ac_engine_components that referenced this pull request Aug 18, 2025
…n#228)

Removed model ID from SimpleUICard in FragmentCacher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant