Skip to content

feat(components): Implemented setup on ScreenCuller#243

Merged
HoyosJuan merged 2 commits intoThatOpen:mainfrom
HoyosJuan:culling-buggy-with-highlighter
Dec 30, 2023
Merged

feat(components): Implemented setup on ScreenCuller#243
HoyosJuan merged 2 commits intoThatOpen:mainfrom
HoyosJuan:culling-buggy-with-highlighter

Conversation

@HoyosJuan
Copy link
Copy Markdown
Member

@HoyosJuan HoyosJuan commented Dec 30, 2023

Description

This PR does two things:

  1. Implement the configurable interface in the ScreenCuller.
  2. Fixes a culling problem on highlight meshes.
  3. Updated the ScreenCuller example.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@HoyosJuan HoyosJuan added the feature Something new that we could do label Dec 30, 2023
@HoyosJuan HoyosJuan merged commit ff3328a into ThatOpen:main Dec 30, 2023
@HoyosJuan HoyosJuan deleted the culling-buggy-with-highlighter branch December 30, 2023 21:12
development-ac pushed a commit to Active-Collective/ac_engine_components that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Something new that we could do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant