feat(Indexes): method generic types for better DX#224
Closed
ShaMan123 wants to merge 2 commits into
Closed
Conversation
8 tasks
agviegas
added a commit
that referenced
this pull request
May 29, 2026
Add generic type params to the index read methods so callers no longer need manual casts. Extends the generics to the getIndexKey/getIndexValues helpers from #215, keeps getInverseIndexEntry's nullable return honest, and fixes a latent getValues type error. Co-Authored-By: ShaMan123 <34343793+ShaMan123@users.noreply.github.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Thanks @ShaMan123! This landed on Since #215 had already merged and touched the same methods, I rebased your generics on top of it and extended them to the Closing as merged via squash. Much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add generic types to index read methods for ease of use
Before
After
Additional context
#215 needs to be patched with a generic type
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).