fix(SingleThreadedFragmentsModel)!: apply common fragments model interface#227
Open
ShaMan123 wants to merge 8 commits into
Open
fix(SingleThreadedFragmentsModel)!: apply common fragments model interface#227ShaMan123 wants to merge 8 commits into
ShaMan123 wants to merge 8 commits into
Conversation
Contributor
Author
|
Methods that can be added to getGuids() {
return this._virtualModel.getGuids();
}
getItemsWithGeometryCategories() {
return this._virtualModel.getItemsWithGeometryCategories();
}
getItemsVolume(localIds: number[]) {
return this._virtualModel.getItemsVolume(localIds);
}
getAttributeNames() {
return this._virtualModel.getAttributeNames();
}
getAttributeValues() {
return this._virtualModel.getAttributeValues();
}
getAttributeTypes() {
return this._virtualModel.getAttributeTypes();
}
getRelationNames() {
return this._virtualModel.getRelationNames();
}
getAttributesUniqueValues(params: AttributesUniqueValuesParams[]) {
return this._virtualModel.getAttributesUniqueValues(params);
}
getItemsMaterialDefinition(localIds: number[]) {
return this._virtualModel.getItemsMaterialDefinition(localIds);
}
getMergedBox(localIds: number[]) {
return this._virtualModel.getBBoxes(localIds);
}
getBoxes(localIds?: number[]) {
const ids = localIds ?? (this._virtualModel.getLocalIds() as number[]);
return ids.map((id) => this._virtualModel.getBBoxes([id]));
}
setLodMode(lodMode: LodMode) {
this._virtualModel.setLodMode(lodMode);
} |
…`getItemsIdsWithGeometry`
9e82a89 to
40961c6
Compare
c99c6db to
c428f5a
Compare
ShaMan123
commented
May 30, 2026
| * Get all the items of the model that have geometry. | ||
| */ | ||
| getItemsWithGeometry() { | ||
| getItemsIdsWithGeometry() { |
| * @param localIds - The local IDs of the items to look up. | ||
| */ | ||
| getPositions(localIds: number[]) { | ||
| getPositions(localIds?: number[]) { |
Contributor
Author
There was a problem hiding this comment.
fixed signature, non breaking
ShaMan123
commented
May 30, 2026
Contributor
Author
ShaMan123
left a comment
There was a problem hiding this comment.
Ready for review
Regarding file/interface naming please suggest to desired pattern so I can align with standards.
Contributor
Author
|
Should |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #216
asyncdirectivesSingleThreadedFragmentsModel#getItemsWithGeometrytogetItemsWithGeometryfor compat withFragmentsModelgetItemsVolumeAdditional context
Misalignments — methods present in one class but absent (or internal) in the other
FragmentsModelonly (missing fromSingleThreadedFragmentsModel):getGuids()— VirtualFragmentsModel exposes this but SingleThreaded does not.getItemsWithGeometryCategories()— same situation.getItemsIdsWithGeometry()— FragmentsModel only.getCoordinationMatrix()— FragmentsModel only.getMergedBox()/getBoxes()— FragmentsModel only.getAlignments()/getHorizontalAlignments()/getVerticalAlignments()/getAlignmentStyles()— FragmentsModel only.getGrids()/getGridMaterial()/setGridMaterial()/getGridLabelMaterial()/setGridLabelMaterial()— FragmentsModel only.useCamera()/setLodMode()— FragmentsModel only.raycast()/raycastAll()/raycastWithSnapping()/rectangleRaycast()— FragmentsModel only.setVisible()/toggleVisible()/resetVisible()/getVisible()/getItemsByVisibility()— FragmentsModel only.highlight()/setColor()/resetColor()/setOpacity()/resetOpacity()— FragmentsModel only.getHighlight()/resetHighlight()/getHighlightItemIds()— FragmentsModel only.getItemsMaterialDefinition()— FragmentsModel only.getAttributesUniqueValues()— FragmentsModel only.getEditedElements()— FragmentsModel only.getItemsVolume()— FragmentsModel only.getAttributeNames()/getAttributeValues()/getAttributeTypes()/getRelationNames()— FragmentsModel only.getGeometries()— FragmentsModel only.getItem()— FragmentsModel only.SingleThreadedFragmentsModelonly (absent or internal inFragmentsModel):edit()— public in SingleThreaded;FragmentsModelexposes_edit()(internal) and routes edits through theEditorclass.reset()/save()— same;_reset()/_save()are internal in FragmentsModel.undo()/redo()— SingleThreaded only; no equivalent in FragmentsModel.getRequests()/setRequests()/selectRequest()— SingleThreaded only;_getRequests()etc. are internal in FragmentsModel.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).