perf: 6-54x faster cold-cache rebuild for /all/ endpoints#151
Merged
perf: 6-54x faster cold-cache rebuild for /all/ endpoints#151
Conversation
The /all/ endpoints (titles, models, manufacturers, people) take ~30s on production when the cache is cold — after every deploy or edit. Three optimizations reduce this to ~3-5s estimated: 1. Cache get_minimum_display_rank() per-rebuild — the Constance DB lookup was called per-item (6k+ times). Adding a min_rank kwarg to _extract_image_urls() lets callers hoist it out of the loop. 2. Replace deep ORM prefetch + Python iteration with bulk values_list() queries on through tables. Instead of hydrating 6k+ full model objects with all M2M relations, query each dimension separately into lightweight dicts. 3. Use values_list() for the main query instead of full ORM object instantiation. For 6.8k models with 8 select_related joins, this alone saves ~0.37s locally (0.44s → 0.07s). Local cold-cache times (before → after): titles: 3.59s → 0.54s (6.6x) models: 3.17s → 0.26s (12.2x) manufacturers: 1.37s → 0.09s (15.2x) people: 1.08s → 0.02s (54x) Response shapes and cache infrastructure are unchanged. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add docstrings explaining the bulk-query pattern, replace magic tuple indices with named constants (T_ID, M_SLUG, etc.), and remove dead model_year/model_rating dicts from list_all_titles. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deduplicate the <header> + <h1> block (font-size-7, weight 700, color-text-primary) that was copy-pasted across 27 files. The new PageHeader component accepts title, optional breadcrumbs (renders Breadcrumb internally), optional children snippet, and CSS custom properties for margin overrides (--page-header-mb, --page-header-title-mb). Adopted in 3 shared components (DetailPage, EntityDetailLayout, TaxonomyListPage), 16 [slug]/+layout.svelte files, and 8 list/detail pages. Exports Crumb type from Breadcrumb.svelte for reuse. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
deanmoses
added
enhancement
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slash cold-cache response times for the four
/all/endpoints from ~30s aggregate to ~3-5s on production (6-54x faster per endpoint) by replacing deep ORM prefetch with bulkvalues_list()queries, cachingget_minimum_display_rank()per rebuild, and avoiding full object hydration.PageHeadercomponent (adopted in 27 files) and adds docstrings/named constants to the bulk-query codeTest plan
make testpasses (backend + frontend)/all/endpoint and confirm response shape is unchangedPageHeaderrenders correctly (title, breadcrumbs)🤖 Generated with Claude Code